Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix: if $mail->reply_to is set, use that (instead of $mail->from) in the email headers #3023

Merged
merged 1 commit into from Sep 18, 2015

Conversation

Projects
None yet
3 participants
@steefdw
Copy link
Contributor

steefdw commented May 17, 2015

If someone would ever use

    $mail = new Mail();
    $mail->setReplyTo($reply_to);
    ...
    $mail->send();

Make sure the reply-to email address that is being set in $mail->setReplyTo($reply_to); is being used, instead of the $mail->from, when creating the email headers here:

$header .= 'Reply-To: =?UTF-8?B?' . base64_encode($this->reply_to) . '?=' . 
           ' <' . $this->reply_to . '>' . $this->newline;

Bug was introduced here 7851910

Note: although setReplyTo() is not used anywhere yet, it's very useful when sending an email on somebody else's behalf. So if one would every use it, this bug is fixed here.

if $mail->reply_to is set, set the reply-to email address to the $mai…
…l->reply_to email address (instead of the $mail->from)
@danielkerr

This comment has been minimized.

Copy link
Contributor

danielkerr commented Sep 18, 2015

fine

danielkerr added a commit that referenced this pull request Sep 18, 2015

Merge pull request #3023 from steefdw/bugfix_reply_to
Bug fix: if $mail->reply_to is set, use that (instead of $mail->from) in the email headers

@danielkerr danielkerr merged commit ad04288 into opencart:master Sep 18, 2015

@avcadvaanz

This comment has been minimized.

Copy link

avcadvaanz commented Nov 26, 2015

Dear All,
How to configure the mail or smtp settings in open cart 2.1.0.1
please let me know anything of thil mail configuration.awaiting for your reply.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.