Fixing summernote core file #4749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: When using multiple instances of summernote on admin this error come to console "node is null", this break the js flow and besides not letting the summernote take more than one textarea it break other js parts Solution: Instead of just making sure the node is text it also checks if the node really exists before trying to get its proprieties Now: If the node does not exist or for some reason is not true or do not have value we return false to the function. Also, as seen in https://github.com/summernote/summernote/blob/develop/src/js/base/core/dom.js#L200 They changed it in the summernote core.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
When using multiple instances of summernote on admin this error come to console "node is null", this break the js flow and besides not letting the summernote take more than one textarea it break other js parts
Solution:
Instead of just making sure the node is text it also checks if the node really exists before trying to get its proprieties
Now:
If the node does not exist or for some reason is not true or do not have value we return false to the function.
Also, as seen in https://github.com/summernote/summernote/blob/develop/src/js/base/core/dom.js#L200
PS: Also in the master branch, into the dist
https://github.com/summernote/summernote/blob/master/dist/summernote.js#L661
They changed it in the summernote core.