Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing language value #5864

Merged
merged 1 commit into from Aug 15, 2017
Merged

Missing language value #5864

merged 1 commit into from Aug 15, 2017

Conversation

evpadallas
Copy link
Contributor

No description provided.

@ADDCreative
Copy link
Contributor

ADDCreative commented Aug 9, 2017

I believe this is wrong. It will show the message to the admin in the customer's language not the admin's.

This is because mail/voucher is loaded based on the order's language.

$language = new Language($order_info['language_code']);
$language->load($order_info['language_code']);
$language->load('mail/voucher');

The text is already in:

$_['text_sent'] = 'Success: Gift Voucher e-mail has been sent!';

Just need to change:

$this->load->language('mail/voucher');
To $this->load->language('sale/voucher');.

This will also fix the missing error_permission caulse by:

$json['error'] = $this->language->get('error_permission');
As error_permission in not in mail/voucher either, but in sale/voucher.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants