Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OC4 Stop reconstructing controllers on each call #8920

Closed
wants to merge 1 commit into from
Closed

OC4 Stop reconstructing controllers on each call #8920

wants to merge 1 commit into from

Commits on Nov 21, 2020

  1. OC4 Stop reconstructing controllers on each call 

    Fix controllers calls:
1. Allows storing variables inside controller classes.
2. Also most 3rd party extensions call lots of init functions on their controllers __construct(). This may cause significant performance loss which is hard to debug.
3. Event system would make things only worse, calling more controller functions and reconstructing controller on each call.
    @stalker780
    stalker780 committed Nov 21, 2020
    Copy the full SHA
    55a9a24 View commit details
    Browse the repository at this point in the history