Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make tool work with Solr removal #623

Merged

Conversation

Arnei
Copy link
Member

@Arnei Arnei commented Mar 14, 2024

Over in Opencast, there is a pull request that makes changes to the Opencast Search Service, breaking the Annotation Tool:
opencast/opencast#5597

Since that pull request 5597 is all but assured to go into Opencast 16, this commit attempts to fix
the errors that 5597 would introduce.

This DOES constitute a breaking change.

Keeping this as a draft for now, since it only works with an Opencast that includes 5597 in its build. If you have access to such an Opencast however, you can already test this PR.

Over in Opencast, there is a pull request that makes
changes to the Opencast Search Service, breaking the
Annotation Tool:
opencast/opencast#5597

Since that pull request 5597 is all but assured to go
into Opencast 16, this commit attempts to fix
the errors that 5597 would introduce.
pom.xml Outdated Show resolved Hide resolved
Copy link
Member

@JulianKniephoff JulianKniephoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good apart from minor nitpicks. Compiled and tested (very rudimentarily) as well, which worked fine.

@JulianKniephoff JulianKniephoff force-pushed the make-work-search-service-rewrite branch from e06550e to c8567d4 Compare June 17, 2024 13:15
Copy link
Member

@JulianKniephoff JulianKniephoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed the nitpicks myself, and tested it locally.

We are waiting for the 16.0 jars to be in central; without those, CI won't be able to build the tool.

@JulianKniephoff JulianKniephoff marked this pull request as ready for review June 25, 2024 15:44
@JulianKniephoff
Copy link
Member

Jars are there now, let's gooo!

@JulianKniephoff JulianKniephoff merged commit d59890f into opencast:master Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants