Remove useAppDispatch from tableThunks.ts #246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Those thunks are likely passed to a `useReducer` somewhere, so we can't have hooks here. We will still want to use useAppDispatch here eventually, but it can wait until we modernized everything else and can finally get to the tables.
|
Merging this without review, because:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #245, which was caused by #214.
Those thunks are likely passed to a
useReducersomewhere, so we can't have hooks here. We will still want to use useAppDispatch here eventually, but it can wait until we migrated everything else to redux toolkit and can finally get to the tables.