Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace title attribute in footer elements with tooltips #793

Merged
merged 1 commit into from
Jul 5, 2024

Conversation

lkiesow
Copy link
Member

@lkiesow lkiesow commented Jul 2, 2024

The footer still used title attributes instead of the tooltips we use everywhere else. This patch fixes that.

@lkiesow lkiesow added the type:visual-clarity Improves UI readability label Jul 2, 2024
Copy link
Contributor

github-actions bot commented Jul 2, 2024

Use docker or podman to test this pull request locally.

Run test server using develop.opencast.org as backend:

podman run --rm -it -p 127.0.0.1:3000:3000 ghcr.io/opencast/opencast-admin-interface:pr-793

Specify a different backend like stable.opencast.org:

podman run --rm -it -p 127.0.0.1:3000:3000 -e PROXY_TARGET=https://stable.opencast.org ghcr.io/opencast/opencast-admin-interface:pr-793

It may take a few seconds for the interface to spin up.
It will then be available at http://127.0.0.1:3000.
For more options you can pass on to the proxy, take a look at the README.md.

Copy link
Contributor

github-actions bot commented Jul 2, 2024

This pull request is deployed at test.admin-interface.opencast.org/793/2024-07-03_20-21-10/ .
It might take a few minutes for it to become available.

Copy link
Member

@Arnei Arnei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe I'm just really confused, but tooltips for the footer are showing for me on main but not anymore on this PR:

main:
Bildschirmfoto vom 2024-07-03 10-03-58

This PR:
Bildschirmfoto vom 2024-07-03 10-05-05

The footer still used `title` attributes instead of the tooltips we use
everywhere else. This patch fixes that.
@lkiesow
Copy link
Member Author

lkiesow commented Jul 3, 2024

Sorry, my bad. Fixing a typing complaint, I actually broke this patch. It's fixed now.

@Arnei Arnei merged commit 251fa66 into opencast:main Jul 5, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:visual-clarity Improves UI readability
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants