Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix style of saved filter sets #818

Merged
merged 2 commits into from
Jul 9, 2024
Merged

Conversation

dennis531
Copy link

@dennis531 dennis531 commented Jul 8, 2024

Changes:

  • Fix class name
  • Use flex box
  • Allow arbitrary word breaks

Close #811, close #809

Changes:
- Fix class name
- Use flexbox
- Allow arbitrary word breaks
@dennis531 dennis531 added type:bug Something isn't working type:visual-clarity Improves UI readability labels Jul 8, 2024
Copy link
Contributor

github-actions bot commented Jul 8, 2024

Use docker or podman to test this pull request locally.

Run test server using develop.opencast.org as backend:

podman run --rm -it -p 127.0.0.1:3000:3000 ghcr.io/opencast/opencast-admin-interface:pr-818

Specify a different backend like stable.opencast.org:

podman run --rm -it -p 127.0.0.1:3000:3000 -e PROXY_TARGET=https://stable.opencast.org ghcr.io/opencast/opencast-admin-interface:pr-818

It may take a few seconds for the interface to spin up.
It will then be available at http://127.0.0.1:3000.
For more options you can pass on to the proxy, take a look at the README.md.

Copy link
Contributor

github-actions bot commented Jul 8, 2024

This pull request is deployed at test.admin-interface.opencast.org/818/2024-07-09_08-17-33/ .
It might take a few minutes for it to become available.

Copy link
Member

@lkiesow lkiesow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Way better than before 🚀

@lkiesow lkiesow self-assigned this Jul 8, 2024
@lkiesow lkiesow merged commit 3e9c011 into opencast:main Jul 9, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Something isn't working type:visual-clarity Improves UI readability
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken alignment of icons in stored filter menu Extremely poor contrast on stored filter button
2 participants