Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix height of filters #831

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

dennis531
Copy link

Basically adds flexbox to elements and removes some useless <span>.

Close #804

Basically adds flexbox to elements
@dennis531 dennis531 added the type:visual-clarity Improves UI readability label Jul 12, 2024
Copy link
Contributor

Use docker or podman to test this pull request locally.

Run test server using develop.opencast.org as backend:

podman run --rm -it -p 127.0.0.1:3000:3000 ghcr.io/opencast/opencast-admin-interface:pr-831

Specify a different backend like stable.opencast.org:

podman run --rm -it -p 127.0.0.1:3000:3000 -e PROXY_TARGET=https://stable.opencast.org ghcr.io/opencast/opencast-admin-interface:pr-831

It may take a few seconds for the interface to spin up.
It will then be available at http://127.0.0.1:3000.
For more options you can pass on to the proxy, take a look at the README.md.

Copy link
Contributor

github-actions bot commented Jul 12, 2024

This pull request is deployed at test.admin-interface.opencast.org/831/2024-07-13_10-34-47/ .
It might take a few minutes for it to become available.

src/styles/main.scss Show resolved Hide resolved
src/styles/main.scss Show resolved Hide resolved
@lkiesow lkiesow self-assigned this Jul 12, 2024
Co-authored-by: Lars Kiesow <lkiesow@uos.de>
@dennis531
Copy link
Author

@lkiesow Thanks for these suggestions. It looks much better now.

@dennis531 dennis531 requested a review from lkiesow July 13, 2024 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:visual-clarity Improves UI readability
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Height difference between filter and filter selector
2 participants