-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve visibility of input fields #973
Conversation
Shows a slightly grey (whitesmoke) background and white input fields in light mode. This changes should make the input fields better visible, since they are currently displayed in the same background color. Resolves opencast#932
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works and looks reasonable to me.
While I'd be fine merging this as is, what do you think about using a different background color for the main menu vs the main content? So for example, the keep snow
color for the main menu and only set the main content part to whitesmoke
?
It is a good idea, as it would better separate the menu from the content. |
Hmm, I don't know, what do you think? :D |
Seems fine by me. Can you do a contrast check with e.g. the WAVE browser add-on to check if the contrast is still high enough (for accessibility reasons). |
Seems like the it doesn't make much of a difference. I'm fine merging this either way, I'll let you decide if you want to make more changes. |
Shows a 'snow' white background for the main menu. The button colors are changed to a lighter grey.
The contrast checker could not detect any contrast issues.
I added my latter suggestion with the lighter buttons. |
Shows a slightly grey (whitesmoke) background and white input fields in light mode.
This changes should make the input fields better visible, since they are currently displayed in the same background color.
Resolves #932