Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve visibility of input fields #973

Merged
merged 2 commits into from
Feb 17, 2023

Conversation

dennis531
Copy link
Collaborator

Shows a slightly grey (whitesmoke) background and white input fields in light mode.

This changes should make the input fields better visible, since they are currently displayed in the same background color.

Resolves #932

Shows a slightly grey (whitesmoke) background and white input fields in light mode.

This changes should make the input fields better visible, since they are currently displayed in the same background color.

Resolves opencast#932
@Arnei Arnei added the type:visual-clarity A part of the UI is not visually readable label Feb 1, 2023
Copy link
Member

@Arnei Arnei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works and looks reasonable to me.

While I'd be fine merging this as is, what do you think about using a different background color for the main menu vs the main content? So for example, the keep snow color for the main menu and only set the main content part to whitesmoke?

@dennis531
Copy link
Collaborator Author

It is a good idea, as it would better separate the menu from the content.

@dennis531
Copy link
Collaborator Author

The interface with a white navigation menu looks like this:
image

Should the buttons be displayed in a lighter grey?

@Arnei
Copy link
Member

Arnei commented Feb 14, 2023

Should the buttons be displayed in a lighter grey?

Hmm, I don't know, what do you think? :D

@dennis531
Copy link
Collaborator Author

I would suggest a lighter grey like the following:
image

@Arnei
Copy link
Member

Arnei commented Feb 14, 2023

Seems fine by me. Can you do a contrast check with e.g. the WAVE browser add-on to check if the contrast is still high enough (for accessibility reasons).

@Arnei
Copy link
Member

Arnei commented Feb 15, 2023

Seems like the it doesn't make much of a difference. I'm fine merging this either way, I'll let you decide if you want to make more changes.

Shows a 'snow' white background for the main menu. The button colors are changed to a lighter grey.
@dennis531
Copy link
Collaborator Author

dennis531 commented Feb 17, 2023

Seems fine by me. Can you do a contrast check with e.g. the WAVE browser add-on to check if the contrast is still high enough (for accessibility reasons).

The contrast checker could not detect any contrast issues.

Seems like the it doesn't make much of a difference. I'm fine merging this either way, I'll let you decide if you want to make more changes.

I added my latter suggestion with the lighter buttons.

@Arnei Arnei merged commit 04cddf5 into opencast:main Feb 17, 2023
@dennis531 dennis531 deleted the improve-input-visibility branch February 28, 2023 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:visual-clarity A part of the UI is not visually readable
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Subtitle editor, make input fields better visible
2 participants