Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional Hotkey to play back video in the subtitle editor #979

Merged
merged 1 commit into from
Apr 6, 2023

Conversation

dennis531
Copy link
Collaborator

Currently, users can not play/pause the video in the subtitle input field. These changes solve this problem by introducing an alternate hotkey Strg + Alt + Space to play and pause videos.

Resolves #901

Currently, users can not play/pause the video in the subtitle input field. This changes solve this problem by introducing an alternate hotkey `Strg` + `Alt` + `Space` to play and pause videos.

Resolves opencast#901
@Arnei Arnei added type:usability Usability improvements type:enhancement New feature or request labels Feb 20, 2023
@lkiesow
Copy link
Member

lkiesow commented Apr 5, 2023

@Arnei, you approved. I see the effect that pressing Ctrl, then Alt, then Space doesn't work. Pressing Alt first, then Ctrl, then Space works just fine. I see this in both Firefox and Chromium. Not sure if this conflicts with a system-wide hotkey (nothing seems to happen). Does that work for you? If yes, feel free to merge this.

@Arnei
Copy link
Member

Arnei commented Apr 6, 2023

@lkiesow for me both orders (Ctrl --> Alt, Alt --> Ctrl) work. I recall that you described this problem previously in #739 months ago, so I think this is likely a problem on your end (that more users could have anyway, so it may still be worth investigating).

@Arnei Arnei merged commit a979588 into opencast:main Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:enhancement New feature or request type:usability Usability improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Additional Hotkey to play back video in the subtitle editor
3 participants