Make Thumbnail Optional #1220
Merged
Make Thumbnail Optional #1220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch makes the thumbnail generation in the video editor optional since it causes major performance problems and/or failures on some systems so that a number of Opencast adopters already ended up patching or removing this in one way or another. This does not change the default behavior of Opencast. With the default configuration, this should make Opencast behave in the same way as before.
lkiesow
force-pushed
the
optional-thumbnail-7x
branch
from
1d71f46
to
c68f994
Compare
|
Hi Lars, I will review it now :) This should close https://opencast.jira.com/browse/MH-13346 |
mliradelc
approved these changes
Nov 12, 2019
|
@lkiesow if it's all ok from your part I can merge it. |
|
I'm happy with this. |
lkiesow
added a commit
to lkiesow/opencast
that referenced
this pull request
Dec 8, 2019
This patch changes the default value for enabling the thumbnail generation in the video editor. The new default is for the thumbnail generation to be deactivated since it causes major performance problems and/or failures on some systems so that a number of Opencast adopters already ended up patching or removing this in one way or another. The thumbnail generation was added in Opencast 6 and later made optional due to ongoing issues in Opencast 7.x: opencast#1220 Having this deactivated by default means that people need to conscientiously activate this and will not accidentally run into problems causing workflows to fail.
LinqLover
pushed a commit
to LinqLover/opencast
that referenced
this pull request
Nov 24, 2020
This patch changes the default value for enabling the thumbnail generation in the video editor. The new default is for the thumbnail generation to be deactivated since it causes major performance problems and/or failures on some systems so that a number of Opencast adopters already ended up patching or removing this in one way or another. The thumbnail generation was added in Opencast 6 and later made optional due to ongoing issues in Opencast 7.x: opencast#1220 Having this deactivated by default means that people need to conscientiously activate this and will not accidentally run into problems causing workflows to fail.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch makes the thumbnail generation in the video editor optional
since it causes major performance problems and/or failures on some
systems so that a number of Opencast adopters already ended up patching
or removing this in one way or another.
This does not change the default behavior of Opencast. With the default
configuration, this should make Opencast behave in the same way as
before.
Your pull request should…