Fix processing of odd video width #1269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to the selected chroma subsampling in combination with the libx264 video encoder, processing wideos using the fast test workflow fails if the video has an odd resolution (e.g. 2560x1337). This patch fixes the issue by cropping to the nearest even resolution is these cases.
lkiesow
changed the title
|
@lkiesow Can you link some demo media to tests against? |
|
Sorry. Totally forgot about this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to the selected chroma subsampling in combination with the libx264
video encoder, processing wideos using the fast test workflow fails if
the video has an odd resolution (e.g. 2560x1337).
This patch fixes the issue by cropping to the nearest even resolution is
these cases.
Your pull request should…