Clean up unused code and ignored tests #1291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note that this has a few conflicts. |
pmiddend
force-pushed
the
spring-cleaning-second-try
branch
from
b414bda
to
67955ed
Compare
|
Conflicts are fixed now. |
|
Skimmed the code and did some production tests. Everything seems to work as expected → merged. |
gregorydlogan
added a commit
to gregorydlogan/opencast
that referenced
this pull request
Nov 20, 2020
…ly needed The MediaPackageImpl class does not demarshall from XML without this method, and it was accidentally cleaned up during a cleanup purge. This commit reverts that change, resolving opencast#1860 Fixes opencast#1860
LinqLover
pushed a commit
to LinqLover/opencast
that referenced
this pull request
Nov 24, 2020
…ly needed The MediaPackageImpl class does not demarshall from XML without this method, and it was accidentally cleaned up during a cleanup purge. This commit reverts that change, resolving opencast#1860 Fixes opencast#1860
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the title suggests, this PR cleans up some unused code and also removes tests that have
@Ignoreon them.It was done by applying the
unused declarationinspection to the whole codebase and then hand-picking. Manual work was needed because simply removing all of it would have broken OSGi (because IntelliJ doesn't know aboutactivateand such being actually used) and because not all unused code is bad per se. Stuff like*Queryclasses withwithmethods, for example, and getters in general, I left as is (mostly).I hope I didn't remove too much. Please correct me if I'm wrong. I'd rather not remove useful code, but rotten code just hinders sensible refactorings and makes the code more "static" than it needs to be.