Don't Ask Developers to Register #2813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch makes the admin interface not open the registration form if you enter the interface on `localhost`. This makes devs happy and we wouldn't gather sensible data in these cases anyway.
lkiesow
added
enhancement
elan e.V.
|
It'll still open if we go looking for it though, right? |
|
You can still manually open it or (if you actually want to test the automatic opening) use http://127.0.0.1:8080 |
Arnei
approved these changes
Jul 9, 2021
gregorydlogan
approved these changes
Jul 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch makes the admin interface not open the registration form if
you enter the interface on
localhost. This makes devs happy and wewouldn't gather sensible data in these cases anyway.
Your pull request should…