Don't update events in index twice when changing series metadata #3010
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Right now, the update of events in the index is done twice when triggered by a series metadata change: Once directly in the series service when updating the series in the index, and once asynchronously by the AssetManagerUpdatedEventHandler when doing a snapshot. The first approach is faster, but will only update the index, not the actual event data. So if something goes wrong during the snapshot, this will lead to inconsistency. It's also a bit of a code smell in my opinion to do this twice. So I'd like to remove this, even though it might result in slower performance, because the index should represent the actual state of the data, not the state it will hopefully soon be in. But I'm open to criticism.
KatrinIhler
added
enhancement
elan e.V.
|
This pull request has conflicts ☹ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, the update of events in the index is done twice when triggered by a series metadata change:
Once directly in the series service after updating the series in the index, and once asynchronously by the AssetManagerUpdatedEventHandler when doing a snapshot.
The first approach is faster, but will only update the index, not the actual event data. So if something goes wrong during the snapshot, this will lead to inconsistency. It's also a bit of a code smell in my opinion to do this twice.
So I'd like to remove this, even though it might result in slower performance, because the index should represent the actual state of the data, not the state it will hopefully soon be in. But I'm open to criticism here.