Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Scheduler Conflict Checks #3339

Merged
merged 1 commit into from
Jan 17, 2022

Conversation

lkiesow
Copy link
Member

@lkiesow lkiesow commented Jan 10, 2022

This patch fixes the scheduler's conflict checks which previously broke
spectacularly if someone already ingested media to one of the found
scheduled events.

The scheduler woould then find the conflict but would fail to retrieve
the media package since it wouldn't be the owner of that event in the
asset manager any longer. That does not make a lot of sense for a
conflict check where you just want to get the information.

Your pull request should…

@lkiesow lkiesow added the bug label Jan 10, 2022
lkiesow added a commit to lkiesow/opencast that referenced this pull request Jan 10, 2022
Capture agents often record to filenames containing metadata which
allows us to identify an event by looking at a specific time in the
schedule of a certain location (capture agent).

If `created` and `spatial` metadata could be identified, this patch
allows us to look up the schedule, using all available event data fram
there if we had a unique match.

Data taken from the schedule, overwriting inbox data are:

- All metadata
- Workflow definition
- Workflow configuration

Notes:

- This patch fixes opencast#3240.
- This is based on opencast#3327.
- You want opencast#3339 for this.
lkiesow added a commit to lkiesow/opencast that referenced this pull request Jan 10, 2022
Capture agents often record to filenames containing metadata which
allows us to identify an event by looking at a specific time in the
schedule of a certain location (capture agent).

If `created` and `spatial` metadata could be identified, this patch
allows us to look up the schedule, using all available event data fram
there if we had a unique match.

Data taken from the schedule, overwriting inbox data are:

- All metadata
- Workflow definition
- Workflow configuration

Notes:

- This patch fixes opencast#3240.
- This is based on opencast#3327.
- You want opencast#3339 for this.
@lkiesow lkiesow mentioned this pull request Jan 10, 2022
7 tasks
This patch fixes the scheduler's conflict checks which previously broke
spectacularly if someone already ingested media to one of the found
scheduled events.

The scheduler woould then find the conflict but would fail to retrieve
the media package since it wouldn't be the owner of that event in the
asset manager any longer. That does not make a lot of sense for a
conflict check where you just want to get the information.
@lkiesow lkiesow changed the base branch from r/11.x to r/10.x January 17, 2022 15:53
@gregorydlogan gregorydlogan merged commit 5532449 into opencast:r/10.x Jan 17, 2022
@gregorydlogan gregorydlogan self-assigned this Jan 17, 2022
lkiesow added a commit to lkiesow/opencast that referenced this pull request Jan 17, 2022
Capture agents often record to filenames containing metadata which
allows us to identify an event by looking at a specific time in the
schedule of a certain location (capture agent).

If `created` and `spatial` metadata could be identified, this patch
allows us to look up the schedule, using all available event data fram
there if we had a unique match.

Data taken from the schedule, overwriting inbox data are:

- All metadata
- Workflow definition
- Workflow configuration

Notes:

- This patch fixes opencast#3240.
- This is based on opencast#3327.
- You want opencast#3339 for this.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants