Updates karma-jasmine to 5.1.0 #3933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes opencast#3877 Removed an empty statement in loginControllerSpec.js. Tried to fix up PlayerAdapterFactory tests, but running the same spec for multiple services is apparently something that no other jasmine users do, so this is kinda iffy. Although previously these tests did not run at all and now they at least run for the default factory, so that's still a net plus.
|
This pull request has conflicts ☹ |
lkiesow
added
dependencies
|
This pull request has conflicts ☹ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3877
Removed an empty statement in loginControllerSpec.js.
Tried to fix up PlayerAdapterFactory tests, but running the same spec for multiple services is apparently something that no other jasmine users do, so this is kinda iffy. Although previously these tests did not run at all and now they at least run for the default factory, so that's still a net plus.