Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Helmet LTI Dependency #3940

Merged
merged 3 commits into from
Jul 5, 2022

Conversation

lkiesow
Copy link
Member

@lkiesow lkiesow commented Jul 4, 2022

NPM started complaining about conflicting dependencies in the LTI
module, potentially causing build failures.

The reason for the conflicts was the dependency Helmet, which hasn't
been updated by us for quite some time and also wasn't really used.

This patch removes that dependency, fixing the build process.

…and down the rabbit hole I went. This now also fixes the other issues breaking th build:

  • The six years old mock proxy did no longer load its configuration. Fixed in f2adaeb
  • The autoprefixer caused a deprecation warning, which killed the CI build. Fixed in c412a3f

Your pull request should…

@lkiesow lkiesow added bug dependencies Pull requests that update a dependency file labels Jul 4, 2022
NPM started complaining about conflicting dependencies in the LTI
module, potentially causing build failures.

The reason for the conflicts was the dependency Helmet, which hasn't
been updated by us for quite some time and also wasn't really used.

This patch removes that dependency, fixing the build process.
@lkiesow
Copy link
Member Author

lkiesow commented Jul 4, 2022

That's weird and new…

 > opencast-lti@0.1.0 mock-proxy
> npx http-mock-server --config mock-server-config.json --proxy http://localhost:3000
No config file path set.
Mock server listening on port 8888
  • The server should listen on 7878 (that's why the tests fail)
  • the config is passed to the tool?

This patch kicks out the 6 years old http-mock-server npm module which
refuses to load its configuration and replaces it with a few lines of
Python code.
This patch fixes a deprecation warning which lets the build fail on CI
systems:

> autoprefixer: Replace color-adjust to print-color-adjust.
> The color-adjust shorthand is currently deprecated.

This can be removed once bootstrap (transitive dependency) has been
updated as well.
@gregorydlogan gregorydlogan self-assigned this Jul 5, 2022
@gregorydlogan gregorydlogan merged commit 2d56547 into opencast:develop Jul 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants