Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail early on missing encoding profile #3958

Merged

Conversation

geichelberger
Copy link
Contributor

@geichelberger geichelberger commented Jul 7, 2022

If the encoding profile is missing on a remote node (opencast-worker), the workflow failed with a misleading exception. This PR introduces an exception and fails early instead of ignoring a missing profile and failing later.

@lkiesow lkiesow added the bug label Jul 7, 2022
@mliradelc mliradelc self-requested a review July 13, 2022 08:22
Copy link
Contributor

@mliradelc mliradelc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine for me, but first I need to try it

@mliradelc
Copy link
Contributor

I tried, works as expected, but I don't understand something.

Should fail at the beginning of the task, or at the start of the Encode WoH?

Copy link
Contributor

@mliradelc mliradelc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, works as expected

@mliradelc mliradelc merged commit 4664005 into opencast:r/12.x Jul 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants