MH-13074, Clean up asset manager REST endpoints #410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The asset manager REST endpoints contains a few pieces of weird or duplicated code: - Remove Entwine's functional library for exception handling - Do not duplicate identical methods - Remove broken “If-None-Match” header parameter
lkiesow
commented
Sep 3, 2018
| return noContent(); | ||
| } | ||
| }); | ||
| return snapshot(mediaPackage); |
There was a problem hiding this comment.
This is identical to snapshot anyway
| @HeaderParam("If-None-Match") final String ifNoneMatch) { | ||
| return handleException(new P1Lazy<Response>() { | ||
| @Override public Response get1() { | ||
| if (StringUtils.isNotBlank(ifNoneMatch)) { |
There was a problem hiding this comment.
This is undocumented and makes no sense at all
| } | ||
|
|
||
| throw new WebApplicationException(e, Response.Status.INTERNAL_SERVER_ERROR); | ||
| public static Response handleException(Exception e) { |
There was a problem hiding this comment.
This non-functional programming approach is actually shorter, arguably easier to read and does not require Entwine's functional library
| } else | ||
| return notFound(); | ||
| if (StringUtils.isEmpty(mediaPackageId)) { | ||
| return notFound(); |
There was a problem hiding this comment.
Ugh, shouldn't this be badRequest()? Nevermind, it's the same (incorrect) behaviour.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The asset manager REST endpoints contains a few pieces of weird or
duplicated code: