Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CVE-2022-42889 library upgrade #4332

Merged
merged 1 commit into from
Oct 19, 2022

Conversation

gregorydlogan
Copy link
Member

@gregorydlogan gregorydlogan commented Oct 17, 2022

This pull request upgrades commons-text to handle CVE-2022-42889.

Your pull request should…

@gregorydlogan gregorydlogan added the maintenance This pull request is addressing maintenance issues label Oct 17, 2022
@github-actions
Copy link
Contributor

This pull request has conflicts ☹
Please resolve those so we can review the pull request.
Thanks.

@gregorydlogan gregorydlogan changed the base branch from develop to r/11.x October 17, 2022 21:01
@lkiesow
Copy link
Member

lkiesow commented Oct 18, 2022

Does that problem affect/endanger Opencast? IF so, we probably need to write a security advisory. Or is this not really affecting Opencast and it's more about getting rid of the warnings?

@gregorydlogan
Copy link
Member Author

It's a good question. It's only in animate, but I don't know that module well enough to know how's its used. It would only affect users running specific WOHs which is why I thought this was more of a dep update than a security issue. I'm fine with doing a security notice though.

@gregorydlogan
Copy link
Member Author

Something brought up in the meeting today: Is Karaf itself affected by this, and which version(s) have they patched? I'll track this.

@lkiesow
Copy link
Member

lkiesow commented Oct 19, 2022

In animate, we only use StringEscapeUtils.escapeXml11 to escape strings we then put into XML. That shouldn't be affected. Hence, I don't think Opencast is affected, and we don't need a security advisory. That is, if Karaf isn't affected.

@lkiesow lkiesow self-assigned this Oct 19, 2022
@lkiesow lkiesow merged commit 8d6c864 into opencast:r/11.x Oct 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance This pull request is addressing maintenance issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants