MH-13164, Load catalog for snapshot message effeciently #487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems like a good efficiency fix to target at 6.x ? |
Instead of loading the dublincore XML and de-serialize it into a Java object only to directly serialize it again as XML, we can just load and use the XML directly.
lkiesow
force-pushed
the
t/mh-13164-us-dc-xml-directly
branch
from
f53cefd
to
60d324e
Compare
|
Rebased to |
staubesv
reviewed
Oct 18, 2018
| } | ||
| } | ||
| return new TakeSnapshot(mp.getIdentifier().compact(), MediaPackageParser.getAsXml(mp), dc, | ||
| return new TakeSnapshot(mp.getIdentifier().compact(), MediaPackageParser.getAsXml(mp), dcXml, |
There was a problem hiding this comment.
@lkiesow The semantic difference is that the former code would have failed early in case of an invalid XML while the new code will not check anything considering that data it loads from the workspace but simply pass the content to TakeSnapshot.
Have you considered possible impacts this could have?
staubesv
approved these changes
Oct 24, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of loading the dublincore XML and de-serialize it into a Java
object only to directly serialize it again as XML, we can just load and
use the XML directly.