MH-13179, Fix Video Editor Preview Mode Default #503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The documentation claims the default for the video editor preview mode setting to be `true` which is correct if it is not set at all. However, if an incorrect value is set, the default incorrectly switches over to `false`
|
You could argue that an incorrectly set configuration just yields in undefined behavior as a default usually is meant to be the value that is set if no value has been configured (vs. the value that is set if the configured value is invalid). Anyway, I'm fine with this. |
staubesv
approved these changes
Oct 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The documentation claims the default for the video editor preview mode
setting to be
truewhich is correct if it is not set at all. However,if an incorrect value is set, the default incorrectly switches over to
false