Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MH-13578 Remove obviously unused classes #917

Merged
merged 1 commit into from
May 27, 2019
Merged

MH-13578 Remove obviously unused classes #917

merged 1 commit into from
May 27, 2019

Conversation

staubesv
Copy link
Contributor

@staubesv staubesv commented May 23, 2019

Basically, I've ran mvn de.is24.mavenplugins:deadcode4j-maven-plugin:find -Dmaven.test.skip=true (see https://github.com/Scout24/deadcode4j) to get a list of classes that tool thinks are not used.

The list mainly consisted of false positives, but going through the list, I could identify a number of classes that really seem not to be used. I've also searched the class names in *.xml files (think of OSGI-INF) as that is a way to reference classes.

@staubesv staubesv added the maintenance This pull request is addressing maintenance issues label May 23, 2019
@lkiesow lkiesow self-assigned this May 23, 2019
@lkiesow
Copy link
Member

lkiesow commented May 23, 2019

Will go through this list over the next days and double-check. Thanks for the patch, good idea to automatically check this.

@lkiesow lkiesow merged commit 21d00e4 into opencast:develop May 27, 2019
lkiesow added a commit that referenced this pull request May 27, 2019
… into develop

Pull request #917
  MH-13578 Remove obviously unused classes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance This pull request is addressing maintenance issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants