Warn About Trailing Slash In URL #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch adds a warning if the base URL configuration value ends with a `/`. That configuration should contain nothing of the services paths. Hence, a trailing slash is very likely a configuration issue which needs to be addressed by the user. This fixes opencast#132
|
Maybe instead of just warning, we could actually catch and mitigate those errors with the Seems like it would be just 1-2 additional lines. |
|
I'll take your answere here: https://bitbucket.org/opencast-community/matterhorn/pull-requests/1555/mh-12255-warn-about-path-in-base-url/diff#comment-38314537 I see your point and do aggree with it. Let's keept it simple, stupid. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds a warning if the base URL configuration value ends with
a
/. That configuration should contain nothing of the services paths.Hence, a trailing slash is very likely a configuration issue which needs
to be addressed by the user.
This fixes #132