TASK-944 #60
Merged
TASK-944 #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Task linked: TASK-944 Create a new Meta web service |
|
SonarCloud Quality Gate failed. |
pfurio
requested changes
Jun 10, 2022
commons-lib/pom.xml
Outdated
| @@ -62,5 +62,11 @@ | |||
| <artifactId>slf4j-simple</artifactId> | |||
| <scope>test</scope> | |||
| </dependency> | |||
| <dependency> | |||
There was a problem hiding this comment.
I don't think we need this dependency, do we?
| Assert.assertTrue(isJSONValid(dataFieldDocJSON)); | ||
| } | ||
|
|
||
| public boolean isJSONValid(String test) { |
There was a problem hiding this comment.
This could be checked using ObjectMapper library instead. Something like:
ObjectMapper objectMapper = new ObjectMapper(); Map map = objectMapper.readValue(test, Map.class);
If the parsing works, the json is valid.
| PRIMITIVE_VALUES.put(int.class, "0"); | ||
| PRIMITIVE_VALUES.put(long.class, "0.0"); | ||
| PRIMITIVE_VALUES.put(short.class, "0"); | ||
|
|
pfurio
approved these changes
Jun 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TASK-950