Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Command and rest endpoints for remove operations on variant storage #623

Closed
2 tasks done
j-coll opened this issue Jun 14, 2017 · 3 comments
Closed
2 tasks done

Command and rest endpoints for remove operations on variant storage #623

j-coll opened this issue Jun 14, 2017 · 3 comments

Comments

@j-coll
Copy link
Member

j-coll commented Jun 14, 2017

Since #487, deleting operations on variant storage (studies, files, annotation and statistics) are high level operations in the VariantStorageEngine.

But this methods are now only accessible programmatically. We need to add rest endpoints and commands in the tree command lines (opencga.sh, opencga-analysis.sh and opencga-storage.sh).

Tasks list:

  • opencga-analysis.sh variant remove
  • opencga-storage.sh variant remove
  • Endpoint analysis/variant/remove
  • opencga.sh variant remove
@j-coll j-coll added this to the v1.2.0 milestone Jun 14, 2017
@j-coll j-coll self-assigned this Jun 14, 2017
@j-coll
Copy link
Member Author

j-coll commented Jun 14, 2017

@imedina , could you please check the names for the endpoints and commands?

@imedina
Copy link
Member

imedina commented Jun 16, 2017

They look fine to me. I guess the parameters will be something like:

opencga.sh variant remove -s STUDY --file FILE.VCF

to remove a specific file or just this to remove all files from one study:

opencga.sh variant remove -s STUDY --file all

I prefer to add --file all, otherwise can be error prone.

@j-coll
Copy link
Member Author

j-coll commented Jun 16, 2017

I like the --file all. It is a dangerous operation.

And what about deleting statistics and annotation?

@j-coll j-coll changed the title Command and rest endpoints for deleting operations on variant storage Command and rest endpoints for remove operations on variant storage Jul 31, 2017
@j-coll j-coll closed this as completed Aug 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants