TASK-1562 Pedigree graph with a three-generation family fails to render properly in Family browser detailed tab #2253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ASK-3898, #TASK-1562
…-3898, #TASK-1562
…a model, #TASK-4000, #TASK-1562
jtarraga
changed the title
pfurio
approved these changes
Mar 2, 2023
| @@ -153,6 +153,9 @@ public class Family extends Annotable { | |||
| description = FieldConstants.FAMILY_ROLES) | |||
| private Map<String, Map<String, FamiliarRelationship>> roles; | |||
|
|
|||
| @DataField(id = "b64PedigreeGraph", description = FieldConstants.FAMILY_PEDIGREE_GRAPH) | |||
There was a problem hiding this comment.
Is it really going to be called that way?
There was a problem hiding this comment.
So, finally, this will be an object :
"pedigreeGraph" : {"base64":"..", "json":{...}}
…n addition to the Base64 format, pedigree graph is saved in JSON format too, #TASK-4000, #TASK-1562
…n the Family data model, #TASK-4000, #TASK-1562
pfurio
approved these changes
Mar 9, 2023
j-coll
reviewed
Mar 14, 2023
|
|
||
| import static org.junit.Assert.*; | ||
|
|
||
| public class FamilyAnalysisTest extends GenericTest { |
There was a problem hiding this comment.
Reminder : We'll need to add the @Category to this test once the categories are merged
…s of a given study, #TASK-4067, #TASK-1562
j-coll
approved these changes
Mar 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement pedigree graph.