TASK-464 - Login - Forgot Password option #2439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
opencga-core/src/main/java/org/opencb/opencga/core/common/MailUtils.java
Show resolved
Hide resolved
|
Task linked: TASK-464 Login - Forgot Password option |
…verified during SSL/TLS connections #TASK-464
pfurio
requested changes
May 7, 2024
...c/main/java/org/opencb/opencga/catalog/auth/authentication/CatalogAuthenticationManager.java
Outdated
Show resolved
Hide resolved
opencga-core/src/main/java/org/opencb/opencga/core/common/MailUtils.java
Outdated
Show resolved
Hide resolved
opencga-core/src/main/java/org/opencb/opencga/core/common/MailUtils.java
Show resolved
Hide resolved
j-coll
reviewed
May 7, 2024
| @@ -133,7 +133,8 @@ public OpenCGAResult resetPassword(String userId) throws CatalogException { | |||
| String mailHost = this.emailConfig.getHost(); | |||
| String mailPort = this.emailConfig.getPort(); | |||
| try { | |||
| MailUtils.sendResetPasswordMail(email, newPassword, mailUser, mailPassword, mailHost, mailPort); | |||
| MailUtils.sendResetPasswordMail(email, newPassword, mailUser, mailPassword, mailHost, mailPort, | |||
| "true", ((User) user.getResults().get(0)).getId()); | |||
There was a problem hiding this comment.
This hardcoded ssl = "true" should be in the configuration file. And should be a boolean instead of String.
There was a problem hiding this comment.
All the variables that are set in the code and are not in the configuration are necessary for the current version to work..... The objective of this task was to change the body of the email message. In the tests I discovered that it did not work with the current configuration, I have added those properties to make it work, if you want to bring that to the configuration it must be done in another requirement, which must be planned for the corresponding version because this must be released now.
pfurio
previously approved these changes
May 9, 2024
pfurio
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://app.clickup.com/t/24qrh5u