Add an option to trust headers set by reverse proxies #1162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carnage
changed the title
carnage
changed the title
eg Cloudflare, kubernetes ingresses etc
chartjes
requested changes
Oct 4, 2018
README.md
Outdated
| @@ -252,6 +252,10 @@ mail: | |||
| encryption: tls | |||
| auth_mode: ~ | |||
| ``` | |||
| ### [Running behind a trusted proxy](#run-trusted-proxy) | |||
|
|
|||
| If you are running open cfp behing a proxy server which adds X-Forwarded-For headers (this could be a cloud based load balancer or a service such as cloudflare) you will need to set the environment variable TRUST_PROXIES to true this will ensure that opencfp trusts the headers set by these proxies for the original IP address and ssl mode. Setting this will trust these headers regardless of where the original request originates, so it's advisable to either lock down your instance so that only the trusted proxy can access it, or modifiy the list of trusted proxies in the index.php file to only include the ip addresses of your proxies. | |||
There was a problem hiding this comment.
The project name is OpenCFP
There was a problem hiding this comment.
Apologies for chiming it, but I think it also should be Cloudflare, see https://www.cloudflare.com.
|
Can you take another look, please? |
|
Yep, just haven't had time yet |
chartjes
approved these changes
Nov 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
eg Cloudflare, kubernetes ingresses etc
Going to tidy up and test this tomorrow, putting in a PR as a reminder