Fix: Inject defaults in service provider #921
Conversation
| @@ -22,10 +22,48 @@ | |||
| public function register(Container $app) | |||
| { | |||
| $app[TalkHelper::class] = function ($app) { | |||
| $categories = $app->config('talk.categories'); | |||
|
|
|||
| if ($categories === null) { | |||
There was a problem hiding this comment.
What about something like:
$categories = $app->config('talk.categories') ?: [
'api' => 'APIs (REST, SOAP, etc.)',
'continuousdelivery' => 'Continuous Delivery',
// etc.
];There was a problem hiding this comment.
Could do, but it's just not very readable, so personally I avoid ternary statements like that.
| $categories = $app->config('talk.categories'); | ||
|
|
||
| if ($categories === null) { | ||
| $categories = [ |
There was a problem hiding this comment.
Not even sure if we need any of this functionality, since all of these are defined in
although with different values.
There was a problem hiding this comment.
I assume this is for displaying default values in case they aren't set in the config file.
There was a problem hiding this comment.
Yes, it is, but why would they not be set?
There was a problem hiding this comment.
When it was introduced in this commit: f3b9384, i assume it was so people would have an easier time upgrading.
By now i think it should throw an error if it is not properly set.This would make sure people wouldn't launch their CFP with the wrong categories/types etc
| @@ -22,10 +22,48 @@ | |||
| public function register(Container $app) | |||
| { | |||
| $app[TalkHelper::class] = function ($app) { | |||
| $categories = $app->config('talk.categories'); | |||
|
|
|||
| if ($categories === null) { | |||
There was a problem hiding this comment.
Could do, but it's just not very readable, so personally I avoid ternary statements like that.
This PR
TalkHelperhandle defaults