Fix crash caused by empty named_properties table #410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the named_properties table is empty, the query SELECT max(mappedId) FROM <table> returns NULL, causing a crash in strtol() later. Checking if row[0] is not NULL makes the code return MAPISTORE_ERR_DATABASE_OPS instead of crashing.
|
👍 |
jkerihuel
added a commit
that referenced
this pull request
Dec 16, 2015
Fix crash caused by empty named_properties table
|
applied, thx @roelvanmeer! |
x0f5c3
added a commit
to rustident/openchange
that referenced
this pull request
Sep 24, 2023
Merge pull request openchange#410 from roelvanmeer/fix-crashes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the named_properties table is empty, the query
SELECT max(mappedId) FROM
returns NULL, causing a crash in strtol() later.
Checking if row[0] is not NULL makes the code return MAPISTORE_ERR_DATABASE_OPS instead of crashing.