Fix build with new libical #424
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updating from upstream
Updating from upstream
This reverts commit f09f827.
Conflicts: CHANGES.md
Conflicts: CHANGES.md
Merge from upstream
Conflicts: CHANGES.md
With this change, the log level set in samba configuration is honored in OC_DEBUG wrapper. Before this patch, if a developer sets the log level to 5, it requires a level 6 in samba configuration to be logged. I think this should be rollbacked once OpenChange uses its own debugging system.
Conflicts: CHANGES.md
Merge from upstream
Reuse memcached connections based on configuration string used on initialization. This normally means that we will have two open connections against memcached: one for indexing and another for notifications and those connections will be reused for all sessions and operations.
shared connections will be cached and not shared connections will not. Shared connection will be used from openchange-samba side (no threading so it's safe to reused them). Right now used in (1) indexing-mysql backend and in (2) mapistore notification. Not shared connections will be used from dovecot openchange plugin. The initialization of mapistore_notification context will have a flag (set on loadparm_context) "mapistore:threading" as true that will be used to create a memcached connection with shared flag disabled. That is because this plugin has concurrency and we cannot use the same memcached object between threads.
Merge from openchange repo
`RAWIDSET_find_by_ID` can return NULL without initialising `last_glob_idset` when the rawidset isn't ID-based. Therefore, if we pass an ID-based idset to this function it will try to access the `next` attribute of a NULL pointer, causing a segmentation fault.
Avoid crash in RAWIDSET_push_eid
In order to avoid sync issues messages when an opening resource failed:
[80040108-501-80040108-1340]
According to [MS-OXCDATA] 2.4.1, the ecNullObject marks that an object handle
reference in the RPC buffer could not be resolved.
From an array of array of bytes to an array of strings.
As follows the result:
pNames : *
pNames: struct StringsArray_r
Count : 0x00000001 (1)
Strings: ARRAY(1)
String : '/o=71e33d1a8e504f67a71be6c253efa397/ou=First Administrative Group/cn=Recipients/cn=bar@foobar.lan'
Both PersistData and PersistElement could had PERSIST_SENTINEL value that indicates they are the last valid value on the array (even if the array has more elements)
oxosfld: stop on PERSIST_SENTINEL
We don't support multivalue instance properties (0x2000 flag). I don't know when they are used (from OL perspective) but we don't want to crash because of an unsupported request
It uses current libmapiserver_push_property but takes array of properties, retvals and values
With libmapiserver_push_property calls
Use proper property type constant
And little refactorization
…int-StringsArray_r-nspi nspi: Beautify StringsArray_r structure output
…nsupported-property-type Do not abort unsupported property type
…bject emsmdb: Replace MAPI_E_INVALID_OBJECT to ecNullObject
Although the final result is equal to 0x0.
mapiproxy/servers/default/emsmdb/oxosfld.c: In function ‘oxosfld_is_special_folder’:
mapiproxy/servers/default/emsmdb/oxosfld.c:181:71: warning: comparison between ‘enum ElementID’ and ‘enum PersistID’ [-Wenum-compare]
if (persist_element.ElementID == PERSIST_SENTINEL) {
…rning-sentinel oxosfld: Fix compilation warning
As defined in [MS-OXCROPS] Section 3.1.4.2 using a dictionary logon_id -> username as Logon object is not required to be created in OpenChange.
And set and retrieve the logon_id accordingly. We have added a check on every implemented ROP the check on failing Logon map as stated by [MS-OXCROPS] Section 3.2.5.1 a non-zero value must be returned. We decided to use MAPI_E_LOGON_FAILED. Additional fixes on documentation
The former is related with EcDoConnect and EcDoConnectEx RPC operations and the user requires to be verified by an external authority in this case Samba AD. The latter is the user provided with Logon ROP and it is used to access the user's mailbox to perform later other operations with that. There were a mixture of them in a single variable emsmdbp_ctx->username which led to wrong results and access to data from authenticated user instead of the logged user and vice versa.
To indicate to NSPI protocol that a user can share but only to the local forest.
Instead of relying on authenticate user available in emsmdbp_ctx->mstore_ctx->conn_info->username because it does not work, because of fmid collisions, when using shared folders.
…g-support Sharing support
|
This branch seems to include more than the described changes. It seems to be against the zentyal openchange repo? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.