Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider removing or making the helm.sh/hook: pre-install annotations optional #555

Closed
chgl opened this issue Nov 2, 2023 · 1 comment · Fixed by #564
Closed

Consider removing or making the helm.sh/hook: pre-install annotations optional #555

chgl opened this issue Nov 2, 2023 · 1 comment · Fixed by #564

Comments

@chgl
Copy link
Contributor

chgl commented Nov 2, 2023

Is your feature request related to a problem? Please describe.

When deploying kubeclarity via argocd I sometimes seem to run into an indefinite sync while ArgoCD is waiting for the hooks to complete. This may be related to argoproj/argo-cd#6880 or argoproj/argo-cd#9018 on ArgoCD's side.

Describe the solution you'd like

The chart sets pre-install hook annotations on some service and secret resources (e.g. https://github.com/openclarity/kubeclarity/blob/main/charts/kubeclarity/templates/service.yaml#L9). I am wondering what the motivation behind them is and if they are necessary in the first place. Helm already installs secret and service resources before any pod or deployment which may depend on them. See the list at https://helm.sh/docs/intro/using_helm/#helm-install-installing-a-package.

Personally, I think we can remove these annotations. I'd be happy to create a PR.

Describe alternatives you've considered

Alternatively, it might be nice to at least disable them.

Additional context

None.

@FrimIdan
Copy link
Member

FrimIdan commented Nov 5, 2023

@Tehsmash / @fishkerez can one of you take a look to see if the pre-install hook can be removed?

chgl added a commit to chgl/kubeclarity that referenced this issue Nov 11, 2023
FrimIdan pushed a commit to chgl/kubeclarity that referenced this issue Dec 20, 2023
github-merge-queue bot pushed a commit that referenced this issue Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants