Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(helm): remove helm.sh/hook annotations #564

Merged
merged 1 commit into from Dec 20, 2023

Conversation

chgl
Copy link
Contributor

@chgl chgl commented Nov 11, 2023

Description

Closes #555 . Alternatively, it could also be an option if required.

Type of Change

[ ] Bug Fix
[ ] New Feature
[ ] Breaking Change
[x] Refactor
[ ] Documentation
[ ] Other (please describe)

Checklist

  • I have read the contributing guidelines
  • Existing issues have been referenced (where applicable)
  • I have verified this change is not present in other open pull requests
  • Functionality is documented
  • All code style checks pass
  • New code contribution is covered by automated tests
  • All new and existing tests pass

@chgl chgl requested a review from a team as a code owner November 11, 2023 14:42
@chgl chgl changed the title fex(helm): remove helm.sh/hook annotations fix(helm): remove helm.sh/hook annotations Nov 13, 2023
@FrimIdan FrimIdan added this pull request to the merge queue Dec 20, 2023
Merged via the queue into openclarity:main with commit 6ef30a4 Dec 20, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Consider removing or making the helm.sh/hook: pre-install annotations optional
2 participants