Added support for calculating common metrics for 2d inputs #13
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
During training over batches of data on PVNet, I was receiving errors due to
common_metrics
returning a float for each metric (RMSE & MAE). For multiple forecast horizons (e.g. every 30 minutes), we needcommon_metrics
to return a 1-d array, so this PR enables support for checking the input predictions array tocommon_metrics
and calculates the mean appropriately depending on the dimensions of the input.Tests have been updated to include 1-d and 2-d input expectations.
Fixes #
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.
Please also list any relevant details for your test configuration
If your changes affect data processing, have you plotted any changes? i.e. have you done a quick sanity check?
Checklist: