Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for calculating common metrics for 2d inputs #13

Merged
merged 2 commits into from
Dec 20, 2023

Conversation

confusedmatrix
Copy link
Contributor

Pull Request

Description

During training over batches of data on PVNet, I was receiving errors due to common_metrics returning a float for each metric (RMSE & MAE). For multiple forecast horizons (e.g. every 30 minutes), we need common_metrics to return a 1-d array, so this PR enables support for checking the input predictions array to common_metrics and calculates the mean appropriately depending on the dimensions of the input.

Tests have been updated to include 1-d and 2-d input expectations.

Fixes #

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.
Please also list any relevant details for your test configuration

  • Yes

If your changes affect data processing, have you plotted any changes? i.e. have you done a quick sanity check?

  • Yes

Checklist:

  • My code follows OCF's coding style guidelines
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked my code and corrected any misspellings

@confusedmatrix confusedmatrix changed the title Added support for calculating common metrics for 2d+ inputs Added support for calculating common metrics for 2d inputs Dec 13, 2023
Copy link

codecov bot commented Dec 13, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (294c3d5) 96.07% compared to head (ef50efa) 96.17%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #13      +/-   ##
==========================================
+ Coverage   96.07%   96.17%   +0.09%     
==========================================
  Files           5        5              
  Lines         153      157       +4     
==========================================
+ Hits          147      151       +4     
  Misses          6        6              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@dfulu dfulu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@dfulu dfulu merged commit 5a3af1c into main Dec 20, 2023
5 of 6 checks passed
@dfulu dfulu deleted the chris/common_metrics-2d branch December 20, 2023 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants