Fix type for SBML history dates (#1301)

* cast to string * cast dates to str * add test model * revert conf
opencobra · Nov 18, 2022 · c234692 · c234692
1 parent 4ef4d79
commit c234692
Show file tree

Hide file tree

Showing 4 changed files with 1,464 additions and 2 deletions.
diff --git a/release-notes/next-release.md b/release-notes/next-release.md
@@ -6,6 +6,9 @@
 
 Fix automatic building of the documentation.
 
+Fix an issue where SBML models with a "created" date would break lots of the cobrapy
+functionality.
+
 ## Other
 
 ## Deprecated features

diff --git a/src/cobra/io/sbml.py b/src/cobra/io/sbml.py
@@ -606,7 +606,7 @@ def _sbml_to_model(
         history: "libsbml.ModelHistory" = model.getModelHistory()
 
         if history.isSetCreatedDate():
-            created = history.getCreatedDate()
+            created = history.getCreatedDate().getDateAsString()
 
         c: "libsbml.ModelCreator"
         for c in history.getListCreators():
@@ -1237,7 +1237,7 @@ def _model_to_sbml(
 
         history: "libsbml.ModelHistory" = libsbml.ModelHistory()
         if "created" in meta and meta["created"]:
-            history.setCreatedDate(meta["created"])
+            history.setCreatedDate(libsbml.Date(meta["created"]))
         else:
             time = datetime.datetime.now()
             timestr = time.strftime("%Y-%m-%dT%H:%M:%S")