Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: cobra.io.mat #1153

Merged
merged 2 commits into from
Feb 24, 2022
Merged

refactor: cobra.io.mat #1153

merged 2 commits into from
Feb 24, 2022

Conversation

synchon
Copy link
Member

@synchon synchon commented Feb 21, 2022

  • fix #(issue number)
  • description of feature/fix
  • tests added/passed
  • add an entry to the next release

This PR adds typing annotations for cobra.io.mat and its unit tests. It also upgrades the code style for them to maintain Python 3.6+ compatibility.

@synchon synchon self-assigned this Feb 21, 2022
Copy link
Member

@cdiener cdiener left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@synchon synchon merged commit 35f5a8b into devel Feb 24, 2022
@synchon synchon deleted the refactor/io-mat branch February 24, 2022 10:26
@synchon synchon mentioned this pull request Mar 4, 2022
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants