Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bring memote back up to speed with recent cobra release #470

Merged
merged 9 commits into from
Jul 25, 2018

Conversation

ChristianLieven
Copy link
Contributor

@ChristianLieven ChristianLieven commented Jul 12, 2018

@ChristianLieven
Copy link
Contributor Author

@Midnighter Do you think we could disable the tests relating to our syntax.py helper module? The functions there are deprecated and not used in any of the core tests.

@Midnighter
Copy link
Member

Absolutely, I will make a quick PR to remove them. Didn't even realize that we're still lugging them around.

@Midnighter
Copy link
Member

Done, so try again after rebasing.

@ChristianLieven
Copy link
Contributor Author

This should not fail anymore once this fix to cobrapy is merged: opencobra/cobrapy#733

@codecov-io
Copy link

codecov-io commented Jul 24, 2018

Codecov Report

Merging #470 into develop will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@          Coverage Diff           @@
##           develop   #470   +/-   ##
======================================
  Coverage        0%     0%           
======================================
  Files           23     23           
  Lines         1159   1156    -3     
  Branches       252    248    -4     
======================================
+ Misses        1155   1152    -3     
  Partials         4      4
Impacted Files Coverage Δ
memote/support/consistency_helpers.py 0% <0%> (ø) ⬆️
memote/support/consistency.py 0% <0%> (ø) ⬆️
memote/support/helpers.py 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 47ebda6...e8773d4. Read the comment docs.

@ChristianLieven ChristianLieven merged commit e331663 into develop Jul 25, 2018
@ChristianLieven ChristianLieven deleted the fix/conform_with_cobra branch July 25, 2018 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unpin Cobrapy Dependency and fix all associated errors
3 participants