-
Notifications
You must be signed in to change notification settings - Fork 213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: skip determination of boundary types when no boundary rxns exist #733
Conversation
Nice catch. The original error you reported was in the heuristic to identify the external compartment, so that probably needs a fix as well... |
@cdiener Am I not sufficiently circumventing that heuristic by skipping |
Codecov Report
@@ Coverage Diff @@
## devel #733 +/- ##
==========================================
- Coverage 82.98% 82.98% -0.01%
==========================================
Files 40 40
Lines 3867 3872 +5
Branches 882 883 +1
==========================================
+ Hits 3209 3213 +4
- Misses 458 459 +1
Partials 200 200
Continue to review full report at Codecov.
|
I agree that it fixes the bug but |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thanks!
Oops saw that there was a mistyped bit of plaintext in my code. :S Removed that in the latest commit. |
Fixes #732