Not hide atoms #24
Draft
Not hide atoms #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I n this comment: #15 (comment) I'm trying to say that you do not need to actually write the "-2" out to the database. That is because the pre-remove and the post-remove calls will come, one right after the other, in the same thread. You'll always know exactly which atom it is, and in what state it is in, so you don't need to write anything out. Did I miss something? |
|
Please note my answer |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
THIS IS A DRAFT! DO NOT MERGE!
This code is work in progress and I might still have some misconceptions.
The main thing happens in
RocksStorage::postRemoveAtominopencog/persist/rocks/RocksIO.cc: Look if we have marked an entry in Rocks (atm still '-2', but this can be changed as mentioned earlier). Then check in AS if it is absent and delete if necessary.This is not meant to compile yet and some smaller parts might still be missing...