You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
So: FIND_PACKAGE(ParallelSTL) works as designed, and cmake sets it correctly:
FIND_PACKAGE(ParallelSTL)
IF (PARALLEL_STL_FOUND)
ADD_DEFINITIONS(-DHAVE_PARALLEL_STL)
ENDIF (PARALLEL_STL_FOUND)
However, the users of oc_omp.h (or at least, this user) do not have a -DHAVE_PARALLEL_STL in their code, nor do they have any #define OC_OMP either. As a result, those wonderful parallel loops are not actually .. parallel.
Moving to c++17 per #177 seems a little more important, now.
The text was updated successfully, but these errors were encountered:
linas
added a commit
to linas/atomspace
that referenced
this issue
Dec 31, 2019
Well, I don't know if this should be re-opened or not ... because I can't tell if its a bug or a feature. Basically, OC_OMP didn't do what I thought it did, and this was a surprise. My plan is to avoid it in new code. So maybe just ignoring this is best.
Follow-on to pull-req #217
So:
FIND_PACKAGE(ParallelSTL)
works as designed, and cmake sets it correctly:However, the users of
oc_omp.h
(or at least, this user) do not have a-DHAVE_PARALLEL_STL
in their code, nor do they have any#define OC_OMP
either. As a result, those wonderful parallel loops are not actually .. parallel.Moving to c++17 per #177 seems a little more important, now.
The text was updated successfully, but these errors were encountered: