Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug-fix missing parallel support. #217

Closed
wants to merge 1 commit into from
Closed

Conversation

linas
Copy link
Member

@linas linas commented Dec 31, 2019

The CMakefile calls this HAVE_PARALLEL_ALGORITHM not HAVE_PARALLEL_STL

The CMakefile calls this `HAVE_PARALLEL_ALGORITHM` not `HAVE_PARALLEL_STL`
@linas linas requested a review from ngeiswei December 31, 2019 04:25
@linas
Copy link
Member Author

linas commented Dec 31, 2019

@ngeiswei -- please take a look.

With stdc++17, I think pretty much everything you want is in std, and so OC_OMP isn't really needed, any more, except for .. what? clang and Apple? I only use OC_OMP in one place ... but .. well, I noticed something was wrong ...

@linas
Copy link
Member Author

linas commented Dec 31, 2019

Actually, this doesn't fix it either, somethings still wrong. OC_OMP is still not defined, even though cmake prints: C++ library standardizes parallelism ... so this is more of a bug-report than a pull-req ....

Oh .. I see, there is also this:

IF (PARALLEL_STL_FOUND)
   ADD_DEFINITIONS(-DHAVE_PARALLEL_STL)
ENDIF (PARALLEL_STL_FOUND)

but that is not working ... arghh...

@linas linas closed this Dec 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant