Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maven rework #13

Merged
merged 1 commit into from
May 16, 2017
Merged

Maven rework #13

merged 1 commit into from
May 16, 2017

Conversation

davidmoten
Copy link
Collaborator

@davidmoten davidmoten commented May 14, 2017

More work will naturally follow following merge especially with .travis setup and Maven Central release automation.

@davidmoten
Copy link
Collaborator Author

looking at openjdk differences now

@davidmoten
Copy link
Collaborator Author

Yep openjdk and oracle jdk have slight rendering differences. I've

  • inspected the images visually
  • fixed the image distance function so variance between pixels is the sum of the squares of the differences of the Red, Green, Blue and Alpha values. Distance is then total variance divided by num pixels in image.
  • set the threshold to 40
  • TODO distance function is copied and pasted to two modules, should create a child module for the distance utility so that it is shared code

@sylvestre
Copy link
Contributor

Impressive work!

@davidmoten davidmoten force-pushed the maven-rework branch 2 times, most recently from fc5aff9 to 68ae206 Compare May 14, 2017 09:21
@davidmoten
Copy link
Collaborator Author

Moved the image distance function used in tests in multiple modules to the core jlatexmath artifact in an internal package (any package labelled internal should not be considered part of the public API).

Squashed commits.

@calixteman
Copy link
Contributor

Are you ready to merge this PR ?

@davidmoten
Copy link
Collaborator Author

Are you ready to merge this PR ?

Yep. There is more cleanup stuff like fixing warnings (unused code, unused imports) but I tried to limit the scope of this work to just the multi-artifact refactor and to add tests (so that I knew my work hadn't broken anything). Other fixes can wait for later PRs. I'll also need to update the docs with build instructions (not tricky mvn clean install), and have a chat with you about releases. Consultation with primary users about the new artifact breakdown will be good too.

@davidmoten
Copy link
Collaborator Author

In case I was ambiguous about being ready to merge, yes we are ready to merge. I'll leave it to you when you' are ready @calixteman.

@calixteman calixteman merged commit fefaa49 into opencollab:master May 16, 2017
@calixteman
Copy link
Contributor

@davidmoten thanks for your work

@davidmoten
Copy link
Collaborator Author

no probs, thanks for yours!

@davidmoten davidmoten deleted the maven-rework branch May 17, 2017 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants