-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Maven rework #13
Maven rework #13
Conversation
looking at openjdk differences now |
Yep openjdk and oracle jdk have slight rendering differences. I've
|
Impressive work! |
fc5aff9
to
68ae206
Compare
Moved the image distance function used in tests in multiple modules to the core jlatexmath artifact in an Squashed commits. |
Are you ready to merge this PR ? |
Yep. There is more cleanup stuff like fixing warnings (unused code, unused imports) but I tried to limit the scope of this work to just the multi-artifact refactor and to add tests (so that I knew my work hadn't broken anything). Other fixes can wait for later PRs. I'll also need to update the docs with build instructions (not tricky |
In case I was ambiguous about being ready to merge, yes we are ready to merge. I'll leave it to you when you' are ready @calixteman. |
@davidmoten thanks for your work |
no probs, thanks for yours! |
More work will naturally follow following merge especially with .travis setup and Maven Central release automation.