Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Transactions Page Follow-Up #4346

Merged
merged 5 commits into from Aug 10, 2020
Merged

Transactions Page Follow-Up #4346

merged 5 commits into from Aug 10, 2020

Conversation

kewitz
Copy link
Contributor

@kewitz kewitz commented Aug 8, 2020

@kewitz kewitz mentioned this pull request Aug 8, 2020
Merged
@kewitz kewitz requested a review from a team August 8, 2020 02:38
Betree
Betree approved these changes Aug 10, 2020
View reviewed changes
Copy link
Member

@Betree Betree left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only a few suggestions for the docs, the code itself looks good 👍

server/graphql/common/transactions.ts Outdated Show resolved Hide resolved
server/graphql/v2/mutation/TransactionMutations.ts Outdated Show resolved Hide resolved
server/graphql/v2/mutation/TransactionMutations.ts Outdated Show resolved Hide resolved
kewitz and others added 2 commits August 10, 2020 15:39
@kewitz @Betree
feat: add refundTransaction() mutation to gqlV2
267ab8c 
Co-Authored-By: Benjamin Piouffle <benjamin.piouffle@gmail.com>
@kewitz @Betree
feat: add TransactionPermission resolver
96b0367 
Co-Authored-By: Benjamin Piouffle <benjamin.piouffle@gmail.com>
@kewitz kewitz force-pushed the fix/transactions-followup-2 branch from 725f962 to 96b0367 Compare August 10, 2020 18:40
@kewitz kewitz merged commit bdb5b90 into master Aug 10, 2020
@kewitz kewitz deleted the fix/transactions-followup-2 branch August 10, 2020 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Betree Betree Betree approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kewitz @Betree