Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Transactions Page Follow-Up #4779

Merged
merged 7 commits into from
Aug 10, 2020
Merged

Transactions Page Follow-Up #4779

merged 7 commits into from
Aug 10, 2020

Conversation

kewitz
Copy link
Contributor

@kewitz kewitz commented Aug 8, 2020

@render
Copy link

render bot commented Aug 8, 2020

Your Render PR Server URL is https://oc-styleguide-pr-4779.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-bsn07vqpp1jte7h1ftmg.

@vercel
Copy link

vercel bot commented Aug 8, 2020 •
edited

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/opencollective/opencollective-frontend/fgjiiy3n1
✅ Preview: https://opencollective-frontend-git-fix-transactions-followup-2.opencollective.vercel.app

@kewitz kewitz force-pushed the fix/transactions-followup-2 branch from 3c81048 to 4d3a1a0 Compare August 8, 2020 02:38
@kewitz kewitz requested a review from a team August 8, 2020 02:44
Betree
Betree reviewed Aug 10, 2020
View reviewed changes
components/StyledLink.js
};

StyledLink.defaultProps = {
colorShade: 500,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't get why we need to customize this prop, links should normally always use the same color no?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was hardcoded to be 500 and 300 on hover.
I added a property to customize so I can update the colors if the background is a bit darker, like the collapsable transaction details where the background is grey.

@kewitz kewitz force-pushed the fix/transactions-followup-2 branch from 4d3a1a0 to 5e43ee4 Compare August 10, 2020 18:40
@kewitz kewitz merged commit df5183e into master Aug 10, 2020
@kewitz kewitz deleted the fix/transactions-followup-2 branch August 10, 2020 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Betree Betree Betree left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kewitz @Betree