VirtualCard: Support refund transactions #6149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
znarf
reviewed
Jun 14, 2021
| privacyTransaction: Transaction, | ||
| opts?: { host?: any; collective?: any; hostCurrencyFxRate?: number }, | ||
| ): Promise<any> => { | ||
| ): Promise<typeof models.Expense | undefined> => { | ||
| const amount = privacyTransaction.settled_amount; |
There was a problem hiding this comment.
What is our guarantee that settled_amount is in USD here. Is it really always the case? Even if the charge is in another currency?
There was a problem hiding this comment.
Yes, they don't even list currency on their schema.
znarf
reviewed
Jun 14, 2021
Co-authored-by: François Hodierne <francois@hodierne.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This covers the missing edge case of refunded virtual card charges.
Notice I'm only creating the transaction pair here, I don't think it makes sense to create an expense with a negative value.