Update react-mde to 6.0.0-alpha.1 #1007
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically deployed with Now. |
znarf
reviewed
Nov 6, 2018
| commands={ReactMdeCommands.getDefaultCommands()} | ||
| commands={this.commands} | ||
| generateMarkdownPreview={markdown => { | ||
| return Promise.resolve(this.converter.makeHtml(markdown)); |
There was a problem hiding this comment.
Why do we need Promise.resolve here?
There was a problem hiding this comment.
react-mde requires a promise to be returned for generateMarkdownPreview. I've added a comment for this.
znarf
reviewed
Nov 6, 2018
znarf
reviewed
Nov 6, 2018
Betree
force-pushed
the
395-update-react-mde
branch
from
87cff73
to
47cf415
Compare
|
Code amended with requested changes |
Betree
force-pushed
the
395-update-react-mde
branch
from
47cf415
to
97b957f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #395
ℹ️
Write/Previewbuttons are not localized yet. I've open an issue to fix a bug preventing from implementing it right now: andrerpena/react-mde#147Changes
react-mdenow demands a string asvalueSee https://github.com/andrerpena/react-mde/blob/master/docs-md/ChangeLogMigrating.md for the full
react-mdechangelog.