Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename ContributeAs onChange Prop to onProfileChange #1496

Merged
merged 9 commits into from
Mar 7, 2019
Merged

Rename ContributeAs onChange Prop to onProfileChange #1496

merged 9 commits into from
Mar 7, 2019

Conversation

flickz
Copy link
Contributor

@flickz flickz commented Mar 5, 2019

Currently there is a prop name mix up between onChange returned by useForm hook and onChange prop of ContributeAs component causing the error in issue 1788.

I renamed onChange prop of ContributeAs to onProfileChange in this PR.

@flickz
Rename contributeAs onChange Prop to onProfileChange
991a25d 
There was a prop name mix up between `onChange` returned by `useForm` hook and `onChange` prop of `ContributeAs` component
@vercel
Copy link

vercel bot commented Mar 5, 2019

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

@flickz flickz requested a review from znarf March 5, 2019 22:16
@znarf znarf requested a review from Betree March 6, 2019 07:54
@znarf
Copy link
Member

znarf commented Mar 6, 2019

@flickz Can you double check if there are similar problems in other components migrated to hooks?

@Betree
Copy link
Member

Betree commented Mar 6, 2019

Can we add a cypress test for that? The test should switch between two existing profiles and ensure that the order is made with the selected one.

@flickz
Copy link
Contributor Author

flickz commented Mar 6, 2019

Sure we can

@Betree
fix(ContributeAs): Broken render on styleguide
965ae4a 
Also updated JSDoc and fixed a crash when there's no `defaultSelectedProfile`
@Betree Betree merged commit c0e9de3 into master Mar 7, 2019
@Betree Betree deleted the fix/contributeAs branch March 7, 2019 14:53
@Betree Betree mentioned this pull request Mar 7, 2019
Closed
@flickz flickz mentioned this pull request Mar 10, 2019
Closed
@PinkDiamond1 PinkDiamond1 mentioned this pull request Jul 31, 2022
Open
@baby636 baby636 mentioned this pull request Jul 31, 2022
Open
@snyk-bot snyk-bot mentioned this pull request Jul 31, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@znarf znarf znarf left review comments

@Betree Betree Betree approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@flickz @znarf @Betree